New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openafs_1_8: 1.8.5 -> 1.8.6 #84968
openafs_1_8: 1.8.5 -> 1.8.6 #84968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to defer this until the 1.8.6 release or at least split it off such that 1.8.5 is used on compatible kernels and 1.8.6pre* is used only on 5.6 kernels. When deployed, AFS is usually a central piece of infrastructure and pre-releases had issues in the past. So, I wouldn't like to surprise anyone with a breaking minor release update.
Does 1.8.6pre2 works with 1.8.5 userland? Than we can make the module depending on the kernel version. |
I made a PR that only cherry-pick the 5.6er fixes into openafs: #88552 |
It usually works out. It is, though, neither supported nor recommended by upstream. Given the significance of a working AFS, my comment above still applies. I would suggest marking it broken on 5.6 kernels until 1.8.6 is released. It would only disturb client updates and no pure server setups. I know this is an nuisance and it is successfully haunting distribution maintainers since the first release of OpenAFS. Let's hope for kafs... |
Can we close this and wait for the next proper release of openafs? |
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
1.8.6 is released now; updated. |
We might want to backport this to 20.03 because linux 5.7 is also present there. |
Opened #91867 for the backport. |
Motivation for this change
Now that
linux_latest
is 5.6, OpenAFS fails to build without these changes.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Succeeded:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_14.openafs_1_8 linuxPackages_4_19.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8 linuxPackages_5_5.openafs_1_8 linuxPackages_5_6.openafs_1_8 linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8 openafs_1_8
.Failed:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest_hardened.openafs_1_8 linuxPackages_latest_xen_dom0_hardened.openafs_1_8 linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8 linuxPackages_xen_dom0_hardened.openafs_1_8
.(The incompatibility with the hardened variant is not a regression.)
./result/bin/
)nix path-info -S
before and after)Cc @maggesi @spacefrogg