Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttyd: 1.5.2 -> 1.6.0 #84966

Merged
merged 1 commit into from Apr 24, 2020
Merged

ttyd: 1.5.2 -> 1.6.0 #84966

merged 1 commit into from Apr 24, 2020

Conversation

iblech
Copy link
Contributor

@iblech iblech commented Apr 11, 2020 •
edited

Motivation for this change

This is just a regular version bump. The version which is currently in nixpkgs, 1.5.2, bundles a version of xterm.js which causes noticeable lag. Thank you for packaging ttyd, your work is very much appreciated :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice April 11, 2020 02:49
@iblech
Copy link
Contributor Author

iblech commented Apr 23, 2020

Just wanted to add, I've been using the new version of ttyd now for a week without any issues. But don't let this remark stress you; I'm totally fine with using the new version in an overlay for the time being.

@thoughtpolice
Copy link
Member

Yeah, I've had high latency recently. Thanks for the updates!

@thoughtpolice thoughtpolice merged commit 6695fdc into NixOS:master Apr 24, 2020
@iblech
Copy link
Contributor Author

iblech commented Apr 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iblech @thoughtpolice