Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freerdp: re-enable tests #85020

Closed
wants to merge 1 commit into from
Closed

freerdp: re-enable tests #85020

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 11, 2020 •
edited

Motivation for this change

Latest version update allows us to re-enable tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Apr 11, 2020
Closed
10 tasks
@peterhoeg
Copy link
Member

This doesn't actually do anything. If you try to build it locally, you will see that the tests aren't running.

You need to set -DBUILD_TESTING=ON and -DWITH_CUNIT=ON for it to run. You will then see the tests run although they do not pass.

@peterhoeg peterhoeg mentioned this pull request Apr 15, 2020
Merged
10 tasks
@prusnak prusnak deleted the freerdp branch April 15, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @peterhoeg