Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ofxtools: unbreak #85018

Merged
merged 1 commit into from Apr 13, 2020
Merged

pythonPackages.ofxtools: unbreak #85018

merged 1 commit into from Apr 13, 2020

Conversation

jonafato
Copy link
Contributor

Motivation for this change

  • Remove sqlalchemy from buildInputs. This dependency was removed in
    0.7.0. Per the project's readme, ofxtools only depends on the
    standard library.

  • Disable for Python versions older than 3.7, the minimum Python version
    supported by ofxtools starting with the 0.8.17 release.

  • Fix the checkPhase by fetching from GitHub instead of PyPI to get a
    distribution that includes tests, overriding the home directory to
    allow tests that depend on it being writeable, and switching to
    nosetests to match the upstream project's test setup.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Apr 11, 2020

@GrahamcOfBorg build python3Packages.ofxtools

das-g
das-g approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@das-g das-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds.

Change LGTM.

@jonafato
pythonPackages.ofxtools: unbreak
b0a3d28 
- Remove `sqlalchemy` from `buildInputs`. This dependency was removed in
  [0.7.0]. Per the project's readme, `ofxtools` only depends on the
  standard library.

- Disable for Python versions older than 3.7, the minimum Python version
  supported by `ofxtools` starting with the [0.8.17] release.

- Fix the `checkPhase` by fetching from GitHub instead of PyPI to get a
  distribution that includes tests, overriding the home directory to
  allow tests that depend on it being writeable, and switching to
  `nosetests` to match the upstream project's test setup.

[0.7.0]: csingley/ofxtools@8a79578
[0.8.17]: csingley/ofxtools@ddeda98
@jonafato jonafato force-pushed the pythonPackages.ofxtools-unbreak branch from 7767ebb to b0a3d28 Compare April 13, 2020 02:40
jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85018 1

2 packages built: - python37Packages.ofxtools - python38Packages.ofxtools

@jonringer jonringer merged commit 2da6401 into NixOS:master Apr 13, 2020
@jonafato jonafato deleted the pythonPackages.ofxtools-unbreak branch April 13, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @FRidh @das-g @jonringer