Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4l2loopback: 0.12.3 -> 0.12.4 #84929

Merged
merged 1 commit into from Apr 10, 2020
Merged

v4l2loopback: 0.12.3 -> 0.12.4 #84929

merged 1 commit into from Apr 10, 2020

Conversation

Trundle
Copy link
Member

@Trundle Trundle commented Apr 10, 2020

Motivation for this change

New upstream release. Fixes build errors with kernel 5.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from domenkozar April 10, 2020 19:02
@jonringer
Copy link
Contributor

blocked for me by #84687

@jonringer
Copy link
Contributor

@GrahamcOfBorg build linuxPackages_latest.v4l2loopback

jonringer
jonringer approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
fixes broken build on master

@jonringer jonringer merged commit 9ddfde8 into NixOS:master Apr 10, 2020
elohmeier pushed a commit to elohmeier/nixpkgs that referenced this pull request May 1, 2020
@Trundle @elohmeier
v4l2loopback: 0.12.3 -> 0.12.4
cf9f88b 
(cherry picked from commit 9ddfde8)
Reason: fixes issue for linuxPackages_latest users in 20.03, see NixOS#84929
@elohmeier elohmeier mentioned this pull request May 1, 2020
Merged
10 tasks
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@Trundle @stigok
v4l2loopback: 0.12.3 -> 0.12.4
c8e152d 
(cherry picked from commit 9ddfde8)
Reason: fixes issue for linuxPackages_latest users in 20.03, see NixOS#84929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Trundle @jonringer