Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethminer: mark as broken #84927

Merged
merged 1 commit into from
Apr 14, 2020
Merged

ethminer: mark as broken #84927

merged 1 commit into from
Apr 14, 2020
+2 −0

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 10, 2020 •
edited
Loading

Doesn't build with gcc9, and if overlayed to use gcc8 stdenv fails on CUDA issues.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 10, 2020
@jonringer
Copy link
Contributor

do you mind adding your comments to the commit message as well. Useful when looking at git history

@bhipple
ethminer: mark as broken

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
7f453f1 
Doesn't build with gcc9, and if overlayed to use gcc8 stdenv fails on CUDA issues.
@worldofpeace worldofpeace merged commit 10f4dfc into NixOS:master Apr 14, 2020
@worldofpeace
Copy link
Contributor

backported to 20.03 in 89b864d

@bhipple bhipple deleted the zhf/ethminer branch June 2, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @jonringer @worldofpeace