Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluidasserts: mark broken #84928

Merged
merged 1 commit into from Apr 12, 2020
Merged

fluidasserts: mark broken #84928

merged 1 commit into from Apr 12, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 10, 2020 •
edited

Motivation for this change

The dependency tree pins many versions to a patch number,
makes it too fragile with how often the packages get bumped.

see similar PR: #80822

the package has been broken for >= 2 weeks (probably closer to a month)
see:
#82867
#82884
#83194
#83211
#83323
#83401
#83441
#83560
#84486
#84540
#84900

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
fluidasserts: mark broken
d9483eb 
The dependency tree pins many versions to a patch number,
makes it too fragile with how often the packages get bumped.
@jonringer jonringer requested a review from FRidh as a code owner April 10, 2020 18:46
@jonringer
Copy link
Contributor Author

#84899

@jonringer
Copy link
Contributor Author

#84894

@jonringer
Copy link
Contributor Author

still broken, going to merge

@jonringer jonringer merged commit 976cb85 into NixOS:master Apr 12, 2020
@jonringer jonringer deleted the disable-fluidasserts branch April 12, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer