Get rid of dependency to SQLite #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build seems to fail due to a configuration issue in github CI: |
edolstra
reviewed
Apr 15, 2020
SQLite isn't properly supported by Hydra for a few years now[1], but Hydra still depends on it. Apart from a slightly bigger closure this can cause confusion by users since Hydra picks up SQLite rather than PostgreSQL by default if HYDRA_DBI isn't configured properly[2] [1] 78974ab [2] https://logs.nix.samueldr.com/nixos-dev/2020-04-10#3297342;
To quote the function's comment: Awful hack to handle timeouts in SQLite: just retry the transaction. DBD::SQLite *has* a 30 second retry window, but apparently it doesn't work. Since SQLite is now dropped entirely, this wrapper can be removed completely.
|
After rebasing onto latest @edolstra anything else to get this merged? :) |
|
Thanks! |
|
With this merged #355 can be closed as well, right? |
|
From my PoV yes (don't have sufficient rights here though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite isn't officially supported for a while. Since it's still used by default, it can lead to confusion by end-users.