-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perlPackages.PDL and dep #85013
perlPackages.PDL and dep #85013
Conversation
b61cc09
to
93ddecd
Compare
Amended and force-pushed. 🙂 |
@invokesus pls change the commit message |
@GrahamcOfBorg build perlPackages.PDL perlPackages.AstroFITSHeader perldevelPackages.PDL perldevelPackages.AstroFITSHeader |
93ddecd
to
d99f808
Compare
Done. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is not supported on darwin
since it depends on glibc. Consider setting platforms = platforms.linux
Tested |
d99f808
to
cdcb352
Compare
Thanks again for the quick review. Really appreciate it! |
cdcb352
to
fb1ff72
Compare
Fixed my typo and added the suggested changes. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GrahamcOfBorg build perlPackages.PDL perldevelPackages.PDL |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Please merge/build after #84600 is merged. Thanks!