Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.PDL and dep #85013

Merged
merged 2 commits into from Sep 15, 2020
Merged

perlPackages.PDL and dep #85013

merged 2 commits into from Sep 15, 2020

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Apr 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Please merge/build after #84600 is merged. Thanks!

pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@invokesus
Copy link
Contributor Author

Amended and force-pushed. 🙂

@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

@invokesus pls change the commit message perlPackages.Astro-FITS-Header: init at 3.07 to perlPackages.AstroFITSHeader: init at 3.07

@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

@GrahamcOfBorg build perlPackages.PDL perlPackages.AstroFITSHeader perldevelPackages.PDL perldevelPackages.AstroFITSHeader

@invokesus
Copy link
Contributor Author

@invokesus pls change the commit message perlPackages.Astro-FITS-Header: init at 3.07 to perlPackages.AstroFITSHeader: init at 3.07

Done. 👍

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package is not supported on darwin since it depends on glibc. Consider setting platforms = platforms.linux

@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

Tested pdl executable OK. Ran demo 3d without problems.

@invokesus
Copy link
Contributor Author

Thanks again for the quick review. Really appreciate it!

@invokesus
Copy link
Contributor Author

Fixed my typo and added the suggested changes. 🙂

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stigtsp
Copy link
Member

stigtsp commented Sep 15, 2020

@GrahamcOfBorg build perlPackages.PDL perldevelPackages.PDL

@stigtsp stigtsp merged commit feda1d6 into NixOS:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants