Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: fc144242d5e1
Choose a base ref
...
head repository: NixOS/nix
compare: ea2148f47cbe
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 10, 2020

  1. Fix nix-build --check -K in sandbox w/o root

    Temporarily add user-write permission to build directory so that it
    can be moved out of the sandbox to the store with a .check suffix.
    
    This is necessary because the build directory has already had its
    permissions set read-only, but write permission is required
    to update the directory's parent link to move it out of the sandbox.
    
    Updated the related --check "derivation may not be deterministic"
    messages to consistently use the real store paths.
    
    Added test for non-root sandbox nix-build --check -K to demonstrate
    issue and help prevent regressions.
    tollb committed Apr 10, 2020
    Copy the full SHA
    8132d0a View commit details
    Browse the repository at this point in the history
  2. Add test case for temporary directories on darwin

    A test case for correct handling of temporary directory deletion that
    was added to check.sh as part of PR #2689 was initially disabled for
    Darwin because of a directory permission issue in PR #2688.
    
    Now that the issue in PR #2688 is fixed, this commit enables the test
    case for Darwin.
    tollb committed Apr 10, 2020
    Copy the full SHA
    e8bd1bc View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Merge pull request #2688 from tollb/fix/build_check_keep_failed_sandb…

    …ox_perms
    
    Fix nix-build --check -K in sandbox w/o root
    domenkozar committed Apr 11, 2020
    Copy the full SHA
    ea2148f View commit details
    Browse the repository at this point in the history