Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.sane: init at 2.8.2 #84935

Closed
wants to merge 1 commit into from
Closed

python.pkgs.sane: init at 2.8.2 #84935

wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Apr 10, 2020 •
edited

Motivation for this change

Needed for https://gitlab.gnome.org/GNOME/ocrfeeder which I tend to package afterwards.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Apr 10, 2020
View reviewed changes
pkgs/development/python-modules/sane/default.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated
@@ -5608,6 +5608,10 @@ in {

safe = callPackage ../development/python-modules/safe { };

sane = callPackage ../development/python-modules/sane {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably match the pypi name, so it feels similar to a typical setup.py or requirements.txt

Suggested change
sane = callPackage ../development/python-modules/sane {
python-sane = callPackage ../development/python-modules/python-sane {

cc @FRidh thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they named the project python-sane to differentiate it from what we call saneBackends. They name themselves just "Sane" on GitHub: https://github.com/python-pillow/Sane

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last push is to mark it as python3 only.

@doronbehar doronbehar mentioned this pull request Apr 10, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

@doronbehar please resolve the merge conflict.

@doronbehar
Copy link
Contributor Author

Fixed merge conflicts and rebased with the commit of this PR in #84939 - this is a dep for the main package added in #84939 .

@doronbehar doronbehar closed this Nov 28, 2020
@doronbehar doronbehar deleted the ocrfeeder branch March 2, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @SuperSandro2000 @jonringer @ryantm