Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtkit: 0.11 -> 0.13 #85030

Merged
merged 2 commits into from Apr 12, 2020
Merged

rtkit: 0.11 -> 0.13 #85030

merged 2 commits into from Apr 12, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Apr 11, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins
Copy link
Contributor

this built for me.
The bins seem to work.

bhipple
bhipple requested changes Apr 12, 2020
View reviewed changes
pkgs/os-specific/linux/rtkit/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/rtkit/default.nix Outdated Show resolved Hide resolved
@bhipple
Copy link
Contributor

bhipple commented Apr 12, 2020

Result of nixpkgs-review pr 85030 1

1 package built:
- rtkit

@bhipple bhipple merged commit 4caa509 into NixOS:master Apr 12, 2020
@eadwu eadwu deleted the rtkit/0.13 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @CloudArtAdmins @bhipple