-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redmine server options #85003
Redmine server options #85003
Conversation
Also, SyslogIdentifier added for the systemd service.
This option allows to choose which Ruby HTTP server runs Redmine: WEBrick or Puma.
@pvgoran looking good 👍 I'll test this in the next week or two. If you're a
|
I'll try to test it during this week.
Did you mean to say that this line ensures that the |
I marked this as stale due to inactivity. → More info |
I need to bring this up to date one day... |
I marked this as stale due to inactivity. → More info |
Motivation for this change
This PR consists of three commits:
prefix
option that allows to specify the URL prefix where Redmine will be served. To allow it to work under, say, https://example.org/redmine instead of https://example.org/ . This commit also includes quality-of-life enhancements: theserverAccessLog
option that allows to disable access logging that WEBrick (HTTP server that runs/hosts Redmine) performs, and addition of theSyslogIdentifier
setting for the systemd service.listen.address
option was added to allow specifying the IP address to listen to (which is quite desirable for security purposes); for unification, theport
option was renamed tolisten.port
.server
option was introduced, which allows to use the Puma HTTP server instead of WEBrick. There is a wide-spread opinion that WEBrick is badly suited for production - although I don't know if it's actually true. Also, in my configuration WEBrick had a specific problem: its access logs show IP address of reverse proxy, rather than IP address of the actual client, whereas Puma shows the client's IP address reported by reverse proxy.The third commit has a potential problem. It relies on the
puma
gem, but its presence is not guaranteed. The Gemfile of Redmine's package includes it in the:test
group, with the comment "For running system tests". At the minimum, this gem's specification needs to be moved to the root level of the Gemfile with the appropriate comment. It would be even better to somehow ensure its presence in theredmine
module; I don't know if it's possible or not.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)