Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdapsgl: 0.5.0 -> 0.7.0 #85005

Merged
merged 1 commit into from Apr 12, 2020
Merged

hdapsgl: 0.5.0 -> 0.7.0 #85005

merged 1 commit into from Apr 12, 2020

Conversation

symphorien
Copy link
Member

We now package a fork on github because:

  • gentoo does it
  • the fork is owned by the same organisation as the one we take hdapsd from.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
hdapsgl: 0.5.0 -> 0.7.0
c8c3181 
We now package a fork on github because:
* gentoo does it
* the fork is owned by the same organisation as the one we take hdapsd
from.
@bhipple
Copy link
Contributor

bhipple commented Apr 12, 2020

Result of nixpkgs-review pr 85005 1

1 package built:
- hdaps-gl

@bhipple bhipple merged commit 6cfcc41 into NixOS:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @bhipple