Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.retworkx: init at 0.3.3 #84945

Closed
wants to merge 3 commits into from
Closed

python3Packages.retworkx: init at 0.3.3 #84945

wants to merge 3 commits into from

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

python3Packages.qiskit-terra is switching from pythonPackages.networkx to pythonPackages.retworkx. I've preliminarily tried to package this thing, but it's somewhat nasty/difficult b/c it's written in Rust then bound to Python via PyO3. PyO3 requires Rust nightly (PyO3/pyo3#5), which obviously isn't available in Nix releases.

So my options are:

  1. Hack some way of compiling this library together
  2. Fetch Wheel from PyPi: https://pypi.org/project/retworkx/#files

2 seems simpler, but the issue is supporting the DIZZYING array of combinations of "python interpreters", "ABIs", and "platforms". Each needs to be specified to get the correct file. Anyone have any recommendations? Best I can find is:

nixpkgs/pkgs/development/python-modules/tensorflow-tensorboard/1/default.nix

Lines 21 to 31 in 84cf00f

src = fetchPypi ({
pname = "tensorboard";
inherit version;
format = "wheel";
} // (if isPy3k then {
python = "py3";
sha256 = "1g62i3nrgp8q9wfsyqqjkkfnsz7x2k018c26kdh527h1yrjjrbac";
} else {
python = "py2";
sha256 = "0l3zc8j2sh7h1z4qpy8kfvclv3kzndri55p10i42q6xahs9phav1";
}));

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger changed the title [WIP][HELP NEEDED PyPi Wheel or Rust in Python]: python3Packages.retworkx: init at 0.3.3 python3Packages.retworkx: init at 0.3.3 Apr 11, 2020
@drewrisinger drewrisinger mentioned this pull request Apr 11, 2020
Merged
10 tasks
@drewrisinger drewrisinger mentioned this pull request Jul 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@drewrisinger