Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoneminder: 1.34.3 -> 1.34.9 #85011

Merged
merged 1 commit into from Apr 11, 2020
Merged

zoneminder: 1.34.3 -> 1.34.9 #85011

merged 1 commit into from Apr 11, 2020

Conversation

danielfullmer
Copy link
Contributor

@danielfullmer danielfullmer commented Apr 11, 2020 •
edited

Motivation for this change

Updated to latest version. Also removed workaround which was included in upstream in ZoneMinder/zoneminder#2867

NixOS module also #84952 needs to work again.

Briefly tested working fine with my zoneminder install.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer
zoneminder: 1.34.3 -> 1.34.9
fae01fa 
Also removed workaround which was included in ZoneMinder/zoneminder#2867
@ofborg ofborg bot requested a review from peterhoeg April 11, 2020 17:45
@garbas garbas merged commit dc75767 into NixOS:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @garbas