Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 479a9b3c0744
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bbdd169400b9
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 11, 2020

  1. gst_all_1.gst-plugins-good: enable jack plugin (#84543) 

    On Linux this adds two dependencies to the closure, libjack2 and celt, which
increases its size from 163.5 MB to 164.4 MB.

This should not cause any issues on macOS since jack supports it.
    @orivej
    orivej authored Apr 11, 2020
    Copy the full SHA
    bbdd169 View commit details
Showing with 5 additions and 7 deletions.
  1. +5 −7 pkgs/development/libraries/gstreamer/good/default.nix
12 changes: 5 additions & 7 deletions pkgs/development/libraries/gstreamer/good/default.nix
View file
Original file line number Diff line number Diff line change
@@ -29,9 +29,7 @@
, mpg123
, twolame
, gtkSupport ? false, gtk3 ? null
# As of writing, jack2 incurs a Qt dependency (big!) via `ffado`.
# In the future we should probably split `ffado`.
, enableJack ? false, jack2
, enableJack ? true, libjack2
, libXdamage
, libXext
, libXfixes
@@ -104,17 +102,17 @@ stdenv.mkDerivation rec {
libavc1394
libiec61883
libgudev
] ++ optionals (stdenv.isLinux && enableJack) [
jack2
] ++ optionals enableJack [
libjack2
];

mesonFlags = [
"-Dexamples=disabled" # requires many dependencies and probably not useful for our users
"-Dqt5=disabled" # not clear as of writing how to correctly pass in the required qt5 deps
] ++ optionals (!gtkSupport) [
"-Dgtk3=disabled"
] ++ optionals (!stdenv.isLinux || !enableJack) [
"-Djack=disabled" # unclear whether Jack works on Darwin
] ++ optionals (!enableJack) [
"-Djack=disabled"
] ++ optionals (!stdenv.isLinux) [
"-Ddv1394=disabled" # Linux only
"-Doss4=disabled" # Linux only