gst-plugins-bad: disable zbar by default #84956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Apr 11, 2020
| @@ -53,7 +53,7 @@ python3.pkgs.buildPythonApplication rec { | |||
| gst_all_1.gstreamer | |||
| gst_all_1.gst-plugins-base | |||
| (gst_all_1.gst-plugins-good.override { gtkSupport = true; }) | |||
| gst_all_1.gst-plugins-bad # for zbar plug-in | |||
| (gst_all_1.gst-plugins-bad.override { enableZbar = true; })# for zbar plug-in | |||
There was a problem hiding this comment.
Suggested change
| (gst_all_1.gst-plugins-bad.override { enableZbar = true; })# for zbar plug-in | |
| (gst_all_1.gst-plugins-bad.override { enableZbar = true; }) # for zbar plug-in |
There was a problem hiding this comment.
I also thought about formatting the expression with nixpkgs-fmt, but that changed quite a lot.
Shall I still do that?
There was a problem hiding this comment.
I think I already formatted it. Using nixpkgs-fmt master I do not see any changes in this expression.
There was a problem hiding this comment.
@jtojnar Well, I do using nixpkgs-fmt 0.6.1
gst-plugins-bad by default used to pull in gtk3 and qtbase and qtx11extras because of the default dependency on zbar. As zbar is a rarely needed gstreamer plugin, this unnecessarily increased the closure size. I am only aware of gnome-keysign actually using the zbar plugin, so that uses a zbar-enabled gst-plugins-bad. closes NixOS#84845
schmittlauch
force-pushed
the
gst-disable-zbar
branch
from
9d77eb1
to
2df7f92
Compare
|
Thanks. |
|
Edit: nevermind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
gst-plugins-bad by default used to pull in gtk3 and qtbase and qtx11extras because of the default dependency on zbar.
As zbar is a rarely needed gstreamer plugin, this unnecessarily
increased the closure size.
I am only aware of gnome-keysign actually using the zbar plugin, so that
uses a zbar-enabled gst-plugins-bad.
closes #84845
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Several packages failed to build, but these failures seem unrelated to this PR.
Full build log:
./result/bin/)nix path-info -Sbefore and after)