Skip to content

python3Packages.ihatemoney: 4.1 -> 4.2 #85023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 6, 2020
Merged

python3Packages.ihatemoney: 4.1 -> 4.2 #85023

merged 13 commits into from
Jul 6, 2020
+179 −12

Conversation

symphorien
Copy link
Member

Update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 11, 2020
@CloudArtAdmins
Copy link
Contributor

What is the package name? I'm not finding it as "ihatemoney".

@symphorien symphorien changed the title ihatemoney: 4.1 -> 4.1.3 python3Packages.ihatemoney: 4.1 -> 4.1.3 Apr 12, 2020
@symphorien
Copy link
Member Author

I fixed the title of the PR. The commit messages are correct.

@symphorien symphorien changed the title python3Packages.ihatemoney: 4.1 -> 4.1.3 WIP: python3Packages.ihatemoney: 4.1 -> 4.2 Apr 25, 2020
@symphorien
Copy link
Member Author

I updated ihatemoney to 4.2 but haven't tested enough yet.

@symphorien symphorien marked this pull request as draft April 25, 2020 10:32
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 25, 2020
@symphorien symphorien changed the title WIP: python3Packages.ihatemoney: 4.1 -> 4.2 python3Packages.ihatemoney: 4.1 -> 4.2 Apr 25, 2020
@symphorien symphorien marked this pull request as ready for review April 25, 2020 16:50
@symphorien
Copy link
Member Author

@GrahamcOfBorg build python3.pkgs.ihatemoney.tests

@symphorien
Copy link
Member Author

@GrahamcOfBorg build python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-postgresql python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-sqlite

@symphorien
Copy link
Member Author

Looks like the PR is ready.

@symphorien
Copy link
Member Author

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 16, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are

  • needs_review, if the author considers this PR ready
  • needs_work if the PR in its current form is not ready yet. Maybe the reviewer requested changes, there is an ongoing discussion or you are waiting for upstream feedback.
  • needs_merge can be set by reviewers who do not have merge permission but would merge this PR if they could.

Anybody can switch the current status with a comment of the form /status <new_status_here>.

Feedback and contributions to this bot are appreciated.

@marvin-mk2 marvin-mk2 bot added the marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2 label Jun 16, 2020
@symphorien
Copy link
Member Author

/status needs_review

@symphorien
Copy link
Member Author

I thought a bit about this, and came to the conclusion that I can override the dependencies of ihatemoney locally because ihatemoney will never be the dependency of something else. It is only a library because it must be imported by uswgi, but it will not be depended upon by some other python module.

I also updated uswgi and removed the now-unneeded workaround. I tested this in a vm, and csv downloading works :)

/status needs_review

@marvin-mk2 marvin-mk2 bot added needs_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Jun 25, 2020
@timokau
Copy link
Member

timokau commented Jun 25, 2020

I agree with your reasoning, since this is a de-facto python application. Still, since we kind of have an (unwritten?) policy against dependency overrides within python-module I'd like @FRidh's okay on this.

@FRidh do you agree that its fine to override the dependencies here, since the module will only ever be used as an application (but through uswgi)?

@timokau
Copy link
Member

timokau commented Jul 1, 2020

@jonringer do you maybe have an opinion on this? See my last comment.

/status needs_work
(work = feedback to get it out of the needs_review queue, will be improved by timokau/marvin-mk2#29)

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed needs_reviewer (old Marvin label, do not use) labels Jul 1, 2020
@timokau
Copy link
Member

timokau commented Jul 6, 2020

Well, lacking any feedback I will just assume its fine. Please add the python.pkgs prefix to ebc28de, then this should be good to go.

I would still prefer to avoid hardcoding the debts rev to enable automatic updates, but If you as the maintainer want to stay on top of updates manually, that is your call.

symphorien added 13 commits July 6, 2020 18:35
@symphorien
nixos/tests/ihatemoney: fix

Verified

This commit was signed with the committer’s verified signature.
jlesquembre José Luis Lafuente
GPG key ID: 8A3455EBE455489A
Verified
Learn about vigilant mode
7971042
@symphorien
python3Packages.ihatemoney: 4.1 -> 4.1.3

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0848c2f
@symphorien
nixos/ihatemoney: work around bug in uwsgi
3603c4e 
happens when dowbloading csv reports
@symphorien
python3Packages.debts: init at 0.5
a71acfe
@symphorien
python3Packages.sqlalchemy-i18n: init at 1.0.3
7918f8c
@symphorien
python3Packages.sqlalchemy-continuum: init a 1.3.9
ed5b736
@symphorien
python3Packages.ihatemoney: 4.1.3 -> 4.2
2720b53
@symphorien
python3Packages.ihatemoney: fix postgresql test
7761494
@symphorien
python3Packages.ihatemoney: disable on python2
4b819d4 
it does not build and is not supported according to setup.cfg
@symphorien
python3Packages.ihatemoney: pin wtforms to 2.2.1
bcafd84
@symphorien
nixos/tests/ihatemoney: fix
2e342f4
@symphorien
uwsgi: 2.0.18 -> 2.0.19.1
826b7c1 
release notes:
https://uwsgi-docs.readthedocs.io/en/latest/Changelog-2.0.19.html
https://uwsgi-docs.readthedocs.io/en/latest/Changelog-2.0.19.1.html
@symphorien
remove workaround for uwsgi < 2.0.19
2b0cfa4
@symphorien
Copy link
Member Author

done. The nixos tests still pass locally.

@marvin-mk2 marvin-mk2 bot added awaiting_reviewer (old Marvin label, do not use) and removed awaiting_changes (old Marvin label, do not use) labels Jul 6, 2020
@timokau
Copy link
Member

timokau commented Jul 6, 2020

Thanks, and thank you for your patience!

@marvin-mk2 marvin-mk2 bot added awaiting_changes (old Marvin label, do not use) and removed awaiting_reviewer (old Marvin label, do not use) labels Jul 6, 2020
@timokau timokau merged commit ed72058 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@timokau timokau

@jonringer jonringer

@schneefux schneefux

@abbradar abbradar

@globin globin

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes awaiting_changes (old Marvin label, do not use) marvin This PR was reviewed by Marvin, a discontinued bot: https://github.com/timokau/marvin-mk2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@symphorien @CloudArtAdmins @timokau @Mic92 @FRidh @jonringer