What is the package name? I'm not finding it as "ihatemoney".

I fixed the title of the PR. The commit messages are correct.

I updated ihatemoney to 4.2 but haven't tested enough yet.

@GrahamcOfBorg build python3.pkgs.ihatemoney.tests

@GrahamcOfBorg build python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-postgresql python3.pkgs.ihatemoney.tests.ihatemoney.ihatemoney-sqlite

Looks like the PR is ready.

/marvin opt-in

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. The stages are

• needs_review, if the author considers this PR ready
• needs_work if the PR in its current form is not ready yet. Maybe the reviewer requested changes, there is an ongoing discussion or you are waiting for upstream feedback.
• needs_merge can be set by reviewers who do not have merge permission but would merge this PR if they could.

Anybody can switch the current status with a comment of the form /status <new_status_here>.

Feedback and contributions to this bot are appreciated.

/status needs_review

I thought a bit about this, and came to the conclusion that I can override the dependencies of ihatemoney locally because ihatemoney will never be the dependency of something else. It is only a library because it must be imported by uswgi, but it will not be depended upon by some other python module.

I also updated uswgi and removed the now-unneeded workaround. I tested this in a vm, and csv downloading works :)

/status needs_review

I agree with your reasoning, since this is a de-facto python application. Still, since we kind of have an (unwritten?) policy against dependency overrides within python-module I'd like @FRidh's okay on this.

@FRidh do you agree that its fine to override the dependencies here, since the module will only ever be used as an application (but through uswgi)?

@jonringer do you maybe have an opinion on this? See my last comment.

/status needs_work
(work = feedback to get it out of the needs_review queue, will be improved by timokau/marvin-mk2#29)

Well, lacking any feedback I will just assume its fine. Please add the python.pkgs prefix to ebc28de, then this should be good to go.

I would still prefer to avoid hardcoding the debts rev to enable automatic updates, but If you as the maintainer want to stay on top of updates manually, that is your call.

done. The nixos tests still pass locally.

Thanks, and thank you for your patience!