Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release notes: Explain how to run nginx master as root #84960

Merged
merged 1 commit into from
Apr 11, 2020
Merged

release notes: Explain how to run nginx master as root #84960

merged 1 commit into from
Apr 11, 2020
+9 −1

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 11, 2020

Fixes #84391.

From #56255 (comment) and #84391 (comment).

Please check that my manual markup is correct :)

CC @flokli @Izorkin @worldofpeace @danbst

Should be cherry-picked on 20.03 after merge.

@nh2
release notes: Explain how to run nginx master as root. Fixes NixOS#8…

Verified

This commit was signed with the committer’s verified signature.
sxzz Kevin Deng 三咲智子
GPG key ID: 69992F2250DFD93E
Verified
Learn about vigilant mode
ba50a7a 
…4391
@nh2 nh2 requested a review from aanderse April 11, 2020 01:01
@nh2 nh2 mentioned this pull request Apr 11, 2020
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 11, 2020
aanderse
aanderse approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nh2 nh2 merged commit f54a639 into NixOS:master Apr 11, 2020
@nh2 nh2 mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running nginx master process as root no longer works correctly
2 participants
@nh2 @aanderse