Skip to content

pico-8: init at 0.1.12c #84999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

pico-8: init at 0.1.12c #84999

wants to merge 2 commits into from
+75 −0

Conversation

amaxine
Copy link
Contributor

@amaxine amaxine commented Apr 11, 2020

Motivation for this change

I wanted to get pico-8 running properly without needing e.g. steamrun.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@amaxine
Copy link
Contributor Author

amaxine commented Apr 11, 2020

Sorry, took me a while to figure out how to fix the libudev problems as they were unobvious... should be ok now!

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 11, 2020
endocrimes
endocrimes approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to not have to steam-run this any more :D

[nixpkgs(master)] $ cd ~/Downloads                                                                                                                                                                                                      
[Downloads] $ nix-prefetch-url file://$PWD/pico-8_0.1.12c_amd64.zip                                                                                                                                                                     
[8.1 MiB DL]                                                                                                                                                                                                                            
path is '/nix/store/v4f4f6fz30czl1p83gjbs2b5j96sq0jg-pico-8_0.1.12c_amd64.zip'

Result of nixpkgs-review pr 84999 1

1 package built:
  • pico-8

Screenshot of game running in a nix-shell:

image

amaxine added 2 commits May 19, 2020 17:19
@amaxine
pico-8: init at 0.1.12c
81e4fee
@amaxine
pico-8: 0.1.12c -> 0.2.0i

Verified

This commit was signed with the committer’s verified signature. The key has expired.
dtzWill Will Dietz
GPG key ID: EBB0EA4124809D02
Expired
Verified
Learn about vigilant mode
fc76186
@amaxine
Copy link
Contributor Author

amaxine commented May 19, 2020

Rebased and bumped version.

@amaxine amaxine closed this Aug 12, 2020
@rileyinman
Copy link
Contributor

Is there a reason this was closed beyond the lack of response? I'm a fan of the idea.

@amaxine
Copy link
Contributor Author

amaxine commented Aug 13, 2020

@rileyinman Sorry, but yeah, that's pretty much it.

@rileyinman
Copy link
Contributor

Unfortunately new package requests can take a bit to get merged, if you don't want to go through the trouble of keeping it up to date I'd be happy to do so based on the derivation you already created!

@amaxine
Copy link
Contributor Author

amaxine commented Aug 13, 2020

I'd be happy to remain maintainer and continue updating the package if it were merged.

The seeming impossibility of that (at least compared to getting open source packages or version bumps merged) has instead made me decide to only do so in my own repository for now. The alternative of leaving a PR open forever seemed undesirable to me, as I don't know what more can be done to get it merged at this point.

@rileyinman
Copy link
Contributor

I believe that you can get help in the unofficial NixOS Discord server, they have a channel for reviewing pull requests to get them merged: https://discord.com/invite/RbvHtGa

@amaxine amaxine deleted the pico-8_0.1.12c branch September 10, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amaxine @rileyinman @endocrimes