Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasmtime: 0.8.0 -> 0.12.0 #81364

Merged
merged 1 commit into from Mar 2, 2020
Merged

wasmtime: 0.8.0 -> 0.12.0 #81364

merged 1 commit into from Mar 2, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 29, 2020 •
edited

Motivation for this change

To reap many benefits, of course!

https://docs.rs/wasmtime/0.12.0/wasmtime/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from matthewbauer February 29, 2020 12:13
@ggreif ggreif changed the title wasmtime: bump to v0.12.0 wasmtime: 0.8.0 -> 0.12.0 Feb 29, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Feb 29, 2020

@GrahamcOfBorg build wasmtime

@ggreif ggreif mentioned this pull request Feb 29, 2020
Closed
@ggreif ggreif marked this pull request as ready for review February 29, 2020 15:45
@ggreif ggreif requested a review from nbp as a code owner February 29, 2020 15:45
@ggreif
wasmtime: bump to v0.12.0 (from v0.8.0)
aaf9975 
- moved to modern cargo fetcher
- removed patch (not needed)
- disabled test (due to bytecodealliance/wasmtime#1197)
@pvgoran
Copy link
Contributor

pvgoran commented Mar 1, 2020

Doing random review.

I was able to build this package using nixpkgs-review pr 81364, and run the binaries it produced.

[nix-shell:~/.cache/nixpkgs-review/pr-81364-3]$ wasmtime --version
wasmtime 0.12.0

[nix-shell:~/.cache/nixpkgs-review/pr-81364-3]$ wasmtime hello.wasm 
Hello, cruel world!

Other binaries (wast, wasm2obj) run too, although I don't know how to check if they are functional or not.

@ggreif
Copy link
Contributor Author

ggreif commented Mar 1, 2020

@pvgoran thanks for testing!

@marsam marsam merged commit 8a863c2 into NixOS:master Mar 2, 2020
@marsam
Copy link
Contributor

marsam commented Mar 2, 2020

Thanks!

@ggreif ggreif deleted the wasmtime-0.12 branch March 2, 2020 14:06
@ggreif
Copy link
Contributor Author

ggreif commented Apr 6, 2020

@matthewbauer @marsam @pvgoran Is it still possible to merge this into release-20.03?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggreif @pvgoran @marsam