Start with types #1233
Merged
Start with types #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
Feb 29, 2020
|
Thank you a lot! |
bhipple
added a commit
to bhipple/nixops-aws
that referenced
this pull request
Mar 22, 2020
Previously, the nixops-aws plugin was always calling `known_hosts.update(old, new, val)`. As of this commit [1], all arguments to the `update` function must be non-null. While we could modify the `update` function in nixops to have the previous behavior, it makes more sense for us to just call `add` when we mean add, and `remove` when we mean remove. [1] NixOS/nixops#1233
bhipple
reviewed
Mar 22, 2020
| remove(prev_address, public_host_key) | ||
| if new_address is not None: | ||
| add(new_address, public_host_key) | ||
| add(new_address, public_host_key) |
There was a problem hiding this comment.
As a heads up, this is a backwards incompatible API change to the function. I think it's a good change, but previously plugins like nixops-aws were calling "update" with None values to mean "remove" or "add". I've fixed nixops-aws by having it call add or remove directly, but it may be worth scanning other plugins to see how they're calling update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few commits. The first batch are cleanup-things of lint flags that my editor told me about; the last one is the one that changes business logic.
I added type annotations to nixops/nixops/known_hosts.py.
I haven't tested this at all, as I'm brand new to the repo and to nixos in general. I'm just fairly familiar with working with static type systems. :)
Looking forward to finding what I've broken.