Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipewire 0.3.0 #81384

Closed
wants to merge 2 commits into from
Closed

Pipewire 0.3.0 #81384

wants to merge 2 commits into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Mutter 3.36 will depend on this https://gitlab.gnome.org/GNOME/mutter/-/blob/84275688f32b1a15a2cb60447ecbf75b526c164a/meson.build#L53

This is a draft because merging this will break stuff until other releases have been made.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace commented Feb 29, 2020
View reviewed changes
pkgs/development/libraries/pipewire/default.nix
};

outputs = [ "out" "lib" "dev" "doc" ];
patches = [
# https://gitlab.freedesktop.org/pipewire/pipewire/-/merge_requests/235
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened this patch so we don't have to do

PKG_CONFIG_SYSTEMD_SYSTEMDUSERUNITDIR = "${placeholder "out"}/lib/systemd/user";

@worldofpeace worldofpeace changed the title Pipewire 3.0 Pipewire 0.3.0 Feb 29, 2020
@ofborg ofborg bot requested a review from jtojnar February 29, 2020 16:41
@worldofpeace worldofpeace added this to To do in GNOME 3.36 Feb 29, 2020
@worldofpeace
Copy link
Contributor Author

Closing because it's dependent on gnome 3.36, it's integrated into #81626

@worldofpeace worldofpeace moved this from To do to Done in GNOME 3.36 Mar 3, 2020
@jtojnar jtojnar deleted the pipewire-3.0 branch April 8, 2020 15:33
@jtojnar jtojnar restored the pipewire-3.0 branch April 8, 2020 15:34
@jtojnar jtojnar reopened this Apr 8, 2020
@jtojnar jtojnar marked this pull request as ready for review April 8, 2020 15:34
@jtojnar jtojnar closed this Apr 8, 2020
@jtojnar jtojnar deleted the pipewire-3.0 branch April 8, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
No open projects
GNOME 3.36
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @jtojnar