Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swaylock-effects: init at 1.6.0 #81306

Closed
wants to merge 3 commits into from
Closed

swaylock-effects: init at 1.6.0 #81306

wants to merge 3 commits into from

Conversation

bram209
Copy link

@bram209 bram209 commented Feb 28, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bram209 bram209 changed the title add swaylock-effects package swaylock-effects init at 1.6.0 Feb 28, 2020
@bram209 bram209 changed the title swaylock-effects init at 1.6.0 swaylock-effects: init at 1.6.0 Feb 28, 2020
@bram209 bram209 mentioned this pull request Feb 28, 2020
Closed
@cole-h
Copy link
Member

cole-h commented Feb 28, 2020

Don't forget to add yourself to the maintainers list in a separate commit titled maintainers: add bram209 (this is why CI is failing). See maintainers-list.nix for instructions and examples.

@bram209
Copy link
Author

bram209 commented Feb 28, 2020

thanks @cole-h, added myself to the list : )

cole-h
cole-h requested changes Feb 28, 2020
View reviewed changes
pkgs/applications/window-managers/sway/lock-effects.nix Outdated Show resolved Hide resolved
pkgs/applications/window-managers/sway/lock-effects.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Show resolved Hide resolved
pkgs/applications/window-managers/sway/lock-effects.nix Outdated Show resolved Hide resolved
@bram209 bram209 force-pushed the master branch 2 times, most recently from ce8346f to 443e62f Compare February 29, 2020 00:04
@bram209
Copy link
Author

bram209 commented Feb 29, 2020

@cole-h thanks for the review, applied all your suggestions

cole-h
cole-h approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn't work for me (pam_authenticate failed: authentication information unavailable), but neither does normal swaylock, and it's likely because I'm not on NixOS.

[3 built, 1 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81306
7 package marked as broken and skipped:
crossLibcStdenv linuxPackages_4_4.sysdig linuxPackages_4_9.sysdig linuxPackages_hardkernel_4_14.sysdig synfigstudio telepathy-salut telepathy_salut

1 package built:
swaylock-effects

@doronbehar
Copy link
Contributor

There's an evaluation error by @GrahamcOfBorg : https://gist.github.com/GrahamcOfBorg/fca3a8a7a7559c3836035ab2e357fa17 .

@cole-h
Copy link
Member

cole-h commented Mar 22, 2020

@GrahamcOfBorg eval

I think this was from when ShellCheck was marked as broken in a Haskell packages update.

cole-h
cole-h reviewed Mar 26, 2020
View reviewed changes
pkgs/applications/window-managers/sway/lock-effects.nix
owner = "mortie";
repo = "swaylock-effects";
rev = "v${version}";
sha256 = "11nap4xylq48pv7qaqxdcz3lbb2hyki8r996rzfzpw467mkxhsr5";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sha256 = "11nap4xylq48pv7qaqxdcz3lbb2hyki8r996rzfzpw467mkxhsr5";
sha256 = "15lshqq3qj9m3yfac65hjcciaf9zdfh3ir7hgh0ach7gpi3rbk13";

Looks like the hash changed, causing build to fail.

@evils
Copy link
Member

evils commented May 19, 2020

closing since #84178 merged nearly the same

@evils evils closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar left review comments

@cole-h cole-h cole-h requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bram209 @cole-h @doronbehar @evils @Janik-Haag