New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python37Packages.fastapi: 0.45.0 -> 0.49.0 #81305
Conversation
Result of 2 package were build:
|
# starlette. Please remove pinning when possible | ||
postPatch = '' | ||
substituteInPlace pyproject.toml \ | ||
--replace "pydantic >=0.32.2,<=0.32.2" "pydantic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do this version patching for starlette
I've reverted to Starlette version 0.12.9. |
@GrahamcOfBorg eval |
- Reverting the version of Starlette as FastAPI can not use anything greater than 0.12.12. FastAPI is Starlette's only dependent. - Use fetchurl instead of fetchPypi as this is now the preferred method. This also makes the tests pass and, thus, the build, which was failing.
- Add peewee to test environment as now required. - Remove pyproject.toml patching as no longer required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commit LGTM
[4 built, 15 copied (4.7 MiB), 1.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81305
2 package built:
python37Packages.fastapi python37Packages.starlette
Motivation for this change
Pin Starlette to verion 0.12.9 due to Broken against latest release of Starlette tiangolo/fastapi#683 otherwise fails to build.
Add peewee to test environment as now required.
Remove pyproject.toml patching as no longer required.
First commit is part of #81304 so that needs to be merged first
These changes need to backported to release-20.03, #80379
This PR partially replaces #81055
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)