Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.fastapi: 0.45.0 -> 0.49.0 #81305

Merged
merged 2 commits into from Mar 13, 2020
Merged

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Feb 28, 2020

Motivation for this change

First commit is part of #81304 so that needs to be merged first

These changes need to backported to release-20.03, #80379

This PR partially replaces #81055

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
Copy link
Contributor Author

wd15 commented Feb 28, 2020

Result of nix-review pr 81305 1

2 package were build:
  • python37Packages.fastapi
  • python37Packages.starlette

pkgs/development/python-modules/fastapi/default.nix Outdated Show resolved Hide resolved
# starlette. Please remove pinning when possible
postPatch = ''
substituteInPlace pyproject.toml \
--replace "pydantic >=0.32.2,<=0.32.2" "pydantic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do this version patching for starlette

@wd15
Copy link
Contributor Author

wd15 commented Feb 28, 2020

I've reverted to Starlette version 0.12.9.

@wd15 wd15 requested a review from jonringer February 28, 2020 22:26
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

wd15 added 2 commits March 2, 2020 11:28
 - Reverting the version of Starlette as FastAPI can not use anything
   greater than 0.12.12. FastAPI is Starlette's only dependent.

 - Use fetchurl instead of fetchPypi as this is now the preferred
   method. This also makes the tests pass and, thus, the build, which
   was failing.
 - Add peewee to test environment as now required.

 - Remove pyproject.toml patching as no longer required.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[4 built, 15 copied (4.7 MiB), 1.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81305
2 package built:
python37Packages.fastapi python37Packages.starlette

@jonringer jonringer merged commit 5634ef5 into NixOS:master Mar 13, 2020
@wd15 wd15 deleted the fastapi-0.49.0 branch March 13, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants