Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scaleft: Init at 1.41.0 #81363

Merged
merged 1 commit into from May 23, 2020
Merged

scaleft: Init at 1.41.0 #81363

merged 1 commit into from May 23, 2020

Conversation

fatpat
Copy link
Contributor

@fatpat fatpat commented Feb 29, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fatpat fatpat changed the title new package scaleft-1.41.0 scaleft: Init at 1.41.0 Feb 29, 2020
evenbrenden
evenbrenden approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@evenbrenden evenbrenden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64 (Ubuntu 18.04)
  • package build on x86_64 (NixOS)
  • executables tested on x86_64 (Ubuntu 18.04)
  • executables tested on x86_64 (NixOS)
  • all depending packages build (Ubuntu 18.04)
  • all depending packages build (NixOS)

@Lassulus Lassulus merged commit 7de2524 into NixOS:master May 23, 2020
@fatpat fatpat deleted the scaleft-1.41.0 branch May 23, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenbrenden evenbrenden evenbrenden approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fatpat @evenbrenden @Lassulus @Janik-Haag