Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvmaf: 1.3.15 -> 1.5.1 #81386

Merged
merged 3 commits into from Feb 29, 2020
Merged

libvmaf: 1.3.15 -> 1.5.1 #81386

merged 3 commits into from Feb 29, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 29, 2020

Motivation for this change

Changelog: https://github.com/Netflix/vmaf/releases/tag/v1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor Author

marsam commented Feb 29, 2020

@GrahamcOfBorg build libvmaf ffmpeg-full

@ofborg ofborg bot requested a review from cfsmp3 February 29, 2020 16:52
cfsmp3
cfsmp3 suggested changes Feb 29, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -11376,7 +11376,6 @@ in
frei0r = if stdenv.isDarwin then null else frei0r;
game-music-emu = if stdenv.isDarwin then null else game-music-emu;
libjack2 = if stdenv.isDarwin then null else libjack2;
libvmaf = if stdenv.isDarwin then null else libvmaf;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually - if I remember correctly, this was needed to avoid build errors? Why remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but only for darwin. I've tested the new version on darwin and it works

@marsam marsam merged commit 63e36a4 into NixOS:master Feb 29, 2020
@marsam marsam deleted the update-libvmaf branch February 29, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfsmp3 cfsmp3 cfsmp3 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @cfsmp3