New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskellPackages.hookup: fix build #81322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you also need to remove the meta.broken = true
entries, you only changed what gets fed into hackage2nix
@GrahamcOfBorg eval |
i don't understand. the only place i know is the file that says not to edit that i thought gets fixed by what i did when hackag2nix runs daily. :( speaking of hackage2nix... i can't get it to work. https://github.com/NixOS/cabal2nix/tree/master/hackage2nix following those instructions it fails to build and i couldn't figure out a way to make it work. i'm trying to fix a bunch of copilot packages and arduino-copilot... i had it working but then i think more things broke. sigh |
the generated file is what nixpkgs actually evaluates. So your build will fail until also edit it. |
you could also fix your nixpkgs to before the commit was introduced. Eventually this will stabilize again |
i had to add an older version of bimap. i edited the hackage-packages.nix manually to add it but i wanted to test if this was right and couldn't run ./update-nixpkgs. and last time i tried on the newest commit there was something else in addition to bimap that didn't match. :|
|
I'll defer to @peti or @cdepillabout to determine the right way forward |
i'll do whatever i can to make it work but i'm not sure what to do either. it's probably easier to figure out on freenode or something than this anyway. if anyone's on there i'm DigitalKiwi or any method listed here is fine too https://mostlyabsurd.com/contact/#socialize-with-me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, except for the two comments above.
In the future, if you'd like to not have to fiddle with keeping glirc up to date, I recommend getting glirc into stackage.
8c42ca0
to
8947cba
Compare
That's fine; 'hackage-packges.nix` will be re-generated automatically based on those changed configuration files. See https://www.youtube.com/watch?v=KLhkAEk8I20 for further details. |
@peti Just for clarification, is it generally okay for people to edit I was under the impression that we don't want people to edit However, if the file is completely regenerated automatically, maybe this isn't actually a concern? The good thing about marking something as non-broken in |
fixes build of glirc
i figured out something that worked and opened an issue. I prefer PRs to issues, but I can make a PR if it's wanted. :) NixOS/cabal2nix#443 |
@Kiwi Thanks for working through this and getting upstream updated! Keep an eye on the |
fixes build of glirc f26c7c7
Motivation for this change
i use glirc and it stopped building because of stackage. again. yay
Things done
glirc needed hookup which needed different network version
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)