Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hookup: fix build #81322

Closed
wants to merge 1 commit into from

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Feb 28, 2020

fixes build of glirc f26c7c7

Motivation for this change

i use glirc and it stopped building because of stackage. again. yay

Things done

glirc needed hookup which needed different network version

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to remove the meta.broken = true entries, you only changed what gets fed into hackage2nix

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@Kiwi
Copy link
Member Author

Kiwi commented Feb 29, 2020

you also need to remove the meta.broken = true entries, you only changed what gets fed into hackage2nix

i don't understand. the only place i know is the file that says not to edit that i thought gets fixed by what i did when hackag2nix runs daily. :( speaking of hackage2nix... i can't get it to work. https://github.com/NixOS/cabal2nix/tree/master/hackage2nix following those instructions it fails to build and i couldn't figure out a way to make it work. i'm trying to fix a bunch of copilot packages and arduino-copilot... i had it working but then i think more things broke. sigh

@jonringer
Copy link
Contributor

the generated file is what nixpkgs actually evaluates. So your build will fail until also edit it.

@jonringer
Copy link
Contributor

'm trying to fix a bunch of copilot packages and arduino-copilot... i had it working but then i think more things broke. sigh

you could also fix your nixpkgs to before the commit was introduced. Eventually this will stabilize again

@Kiwi
Copy link
Member Author

Kiwi commented Feb 29, 2020

'm trying to fix a bunch of copilot packages and arduino-copilot... i had it working but then i think more things broke. sigh

you could also fix your nixpkgs to before the commit was introduced. Eventually this will stabilize again

i had to add an older version of bimap. i edited the hackage-packages.nix manually to add it but i wanted to test if this was right and couldn't run ./update-nixpkgs. and last time i tried on the newest commit there was something else in addition to bimap that didn't match. :|

default-package-overrides:
  # copilot 3.1 needs bimap 0.3.*
  - bimap ==0.3.3
  # pandoc-2.9 does not accept the 0.3 version yet
  - doclayout < 0.3
  # LTS Haskell 14.23

@jonringer
Copy link
Contributor

I'll defer to @peti or @cdepillabout to determine the right way forward

@Kiwi
Copy link
Member Author

Kiwi commented Feb 29, 2020

i'll do whatever i can to make it work but i'm not sure what to do either. it's probably easier to figure out on freenode or something than this anyway. if anyone's on there i'm DigitalKiwi or any method listed here is fine too https://mostlyabsurd.com/contact/#socialize-with-me

Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except for the two comments above.

In the future, if you'd like to not have to fiddle with keeping glirc up to date, I recommend getting glirc into stackage.

@peti
Copy link
Member

peti commented Feb 29, 2020

you also need to remove the meta.broken = true entries, you only changed what gets fed into hackage2nix

That's fine; 'hackage-packges.nix` will be re-generated automatically based on those changed configuration files. See https://www.youtube.com/watch?v=KLhkAEk8I20 for further details.

@cdepillabout
Copy link
Member

cdepillabout commented Feb 29, 2020

@peti Just for clarification, is it generally okay for people to edit hackage-packages.nix by hand to mark a package as not broken, as long as they make sure to also edit configuration-hackage2nix.nix and mark the package as not broken?

I was under the impression that we don't want people to edit hackage-packages.nix (even to simply mark packages as non-broken at the same time they are marked non-broken in configuration-hackage2nix.nix) because it occasionally causes merge conflicts.

However, if the file is completely regenerated automatically, maybe this isn't actually a concern?


The good thing about marking something as non-broken in hackage-packages.nix as well is that you can build the package with ofborg as a double check that it actually builds.

@Kiwi
Copy link
Member Author

Kiwi commented Feb 29, 2020

i had to add an older version of bimap. i edited the hackage-packages.nix manually to add it but i wanted to test if this was right and couldn't run ./update-nixpkgs. and last time i tried on the newest commit there was something else in addition to bimap that didn't match. :|

default-package-overrides:
  # copilot 3.1 needs bimap 0.3.*
  - bimap ==0.3.3
  # pandoc-2.9 does not accept the 0.3 version yet
  - doclayout < 0.3
  # LTS Haskell 14.23

i figured out something that worked and opened an issue. I prefer PRs to issues, but I can make a PR if it's wanted. :) NixOS/cabal2nix#443

@Kiwi Kiwi closed this Feb 29, 2020
@cdepillabout
Copy link
Member

@Kiwi Thanks for working through this and getting upstream updated! Keep an eye on the haskell-updates branch, which should get the update for hookup within a day or so (assuming it has already been updated on Hackage).

@Kiwi Kiwi deleted the glirc-hookup branch March 1, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants