Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carla: properly wrap plugin programs #68795

Merged
merged 2 commits into from Feb 28, 2020
Merged

Carla: properly wrap plugin programs #68795

merged 2 commits into from Feb 28, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

Fixes #67923. @suhr could you test that it works for you?

Also enabled parallel building because it's way faster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

I'm not sure that is necessary

@suhr
Copy link
Contributor

suhr commented Sep 15, 2019

Now it indeed works, though carla-patchbay vst seem to load carla-rack instead.

@suhr suhr mentioned this pull request Sep 15, 2019
Closed
@suhr suhr mentioned this pull request Oct 21, 2019
Closed
@jpotier
Copy link
Contributor

jpotier commented Feb 9, 2020 •
edited

Bumped into the pyQt5 problem with Carla VST today.

I can confirm that this updated expression fixes the pyQt5 library problem. It is definitely an improvement over the current version, and this could be merged now.

I could obsevre too that carla-patchbay loads carla-rack instead. Not clear whether it comes from this nix expression or the upstream project.

@jpotier
Copy link
Contributor

jpotier commented Feb 9, 2020

@minijackson did you make any unpublished progress since september?

@minijackson
Copy link
Member Author

@jpotier no, I think this is all I have

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/96

@JohnAZoidberg
Copy link
Member

@suhr

Now it indeed works, though carla-patchbay vst seem to load carla-rack instead.

Is this a problem with nixpkgs/this patch or with Carla?

@suhr
Copy link
Contributor

suhr commented Feb 16, 2020

I have no idea.

@JohnAZoidberg
Copy link
Member

Hmm.

At least:

It is definitely an improvement over the current version, and this could be merged now.

jpotier
jpotier approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jpotier jpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already beneficial as is

@JohnAZoidberg JohnAZoidberg merged commit 4dfb636 into NixOS:master Feb 28, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 29, 2020
@JohnAZoidberg @dtzWill
Merge pull request NixOS#68795 from minijackson/carla-fix-67923
66c96dd 
Carla: properly wrap plugin programs
(cherry picked from commit 4dfb636)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpotier jpotier jpotier approved these changes

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carla window is black when loaded as a plugin
5 participants
@minijackson @suhr @jpotier @nixos-discourse @JohnAZoidberg