Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] pythonPackages.setuptools: 44.0.0 -> 45.2.0 #81316

Merged
merged 2 commits into from Mar 2, 2020
Merged

[staging] pythonPackages.setuptools: 44.0.0 -> 45.2.0 #81316

merged 2 commits into from Mar 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 28, 2020 •
edited

Motivation for this change

noticed it was out of date

python2 version is frozen at 44.0.0, version 45 dropped support

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.requests
@GrahamcOfBorg build python3Packages.requests
@GrahamcOfBorg build python38Packages.requests

@jonringer jonringer changed the title pythonPackages.setuptools: 44.0.0 -> 45.2.0 [staging] pythonPackages.setuptools: 44.0.0 -> 45.2.0 Feb 28, 2020
@ofborg ofborg bot requested a review from dotlambda February 28, 2020 19:56
@jonringer
Copy link
Contributor Author

cc @FRidh look good to you?

@jonringer jonringer merged commit c3c4754 into NixOS:staging Mar 2, 2020
@jonringer jonringer deleted the bump-setuptools branch July 8, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer