Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

malcontent: 0.4.0 → 0.6.0 #81431

Merged
merged 3 commits into from Mar 11, 2020
Merged

malcontent: 0.4.0 → 0.6.0 #81431

merged 3 commits into from Mar 11, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 1, 2020

At the moment fails due to cyclic dependency https://gitlab.freedesktop.org/pwithnall/malcontent/issues/16

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

At the moment fails due to cyclic dependency https://gitlab.freedesktop.org/pwithnall/malcontent/issues/16

Aww that sucks. I guess the only solution for that, as you mentioned there, is to split the projects up.

@worldofpeace
Copy link
Contributor

It seems @hedning just dropped it from flatpak hedning@cdf3594.

Also heads up @hedning, @jtojnar has already done the bump to 0.6.0 here hedning@60a3fbc.

@hedning
Copy link
Contributor

hedning commented Mar 1, 2020

Yeah, I didn't want to mess around too much. Checked fedora which doesn't enable the malcontent option in flatpak either.

@hedning hedning mentioned this pull request Mar 3, 2020
Merged
@jtojnar jtojnar marked this pull request as ready for review March 10, 2020 22:32
@jtojnar jtojnar requested a review from infinisil as a code owner March 10, 2020 22:32
@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 10, 2020

Let’s just remove it from flatpak for now. Having the module is more convenient for me for testing.

@jtojnar jtojnar merged commit 6bba942 into NixOS:master Mar 11, 2020
@jtojnar jtojnar deleted the malcontent-0.6 branch March 11, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @worldofpeace @hedning