Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: ccd2fa4665b1
Choose a base ref
...
head repository: NixOS/nixops
compare: f691fd5687c4
Choose a head ref
  • 18 commits
  • 1 file changed
  • 1 contributor

Commits on Feb 29, 2020

  1. Remove unused imports, sort typing import, import locals last.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3d3d63b View commit details
    Browse the repository at this point in the history

  2. Move Handler class to top of file, remove object imports.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e007070 View commit details
    Browse the repository at this point in the history

  3. Do the todo! also change the type annotation style.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e99b321 View commit details
    Browse the repository at this point in the history

  4. Change the type signature style, make it explicitly return List[Handler]

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    5ef019b View commit details
    Browse the repository at this point in the history

  5. Polish if-conditional style. Pacify the linter.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    176d91f View commit details
    Browse the repository at this point in the history

  6. Define this in the init, to remove a lint in the set_handlers function.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3c2f127 View commit details
    Browse the repository at this point in the history

  7. Remove unneeded else.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f38ad30 View commit details
    Browse the repository at this point in the history

  8. CI bit me, this does not work, fix and re-try.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    2a7aae7 View commit details
    Browse the repository at this point in the history

  9. Remove duplicate type signatures, thank you CI!

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    1ba4ff6 View commit details
    Browse the repository at this point in the history

  10. Set the default value in a saner way, add type annotation.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    641f9f2 View commit details
    Browse the repository at this point in the history

  11. Add typing.Tuple, define h_tuple type, define keys type.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    26b23ab View commit details
    Browse the repository at this point in the history

  12. Bah, this slipped past me. Remove a crashing type annotation.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f70b7a2 View commit details
    Browse the repository at this point in the history

  13. Remove unused imports, sort typing import, import locals last.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    815a7d6 View commit details
    Browse the repository at this point in the history

  14. CI bit me, this does not work, fix and re-try.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    be31f32 View commit details
    Browse the repository at this point in the history

  15. This seems to work?

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    7609b6c View commit details
    Browse the repository at this point in the history

  16. CI complained that the __future__ import must be at top of file. Fix.

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    225fd36 View commit details
    Browse the repository at this point in the history

  17. Give this another go!

    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    43f1db8 View commit details
    Browse the repository at this point in the history

  18. Revert "Give this another go!" 

    This reverts commit 766e5e8.
    @TheWizardTower @grahamc
    TheWizardTower authored and grahamc committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f691fd5 View commit details
    Browse the repository at this point in the history