nixos/networkd: add RoutingPolicyRules-related options #81405
Conversation
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
d3878db
to
98ae747
Compare
|
@GrahamcOfBorg test systemd-networkd |
|
I'm puzzled by the ARM test error: https://logs.nix.ci/?key=nixos/nixpkgs.81405&attempt_id=adb7ba1f-8fb3-418c-af5a-68f0a2202fad I do not have access to an interactive session on a aarch64 machine, it makes debugging this rather tricky :( Looks like it's IPv6 related right? |
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
98ae747
to
52b3afe
Compare
|
@GrahamcOfBorg test systemd-networkd |
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
52b3afe
to
171cfa3
Compare
|
Aha! Found the root cause of the ARM failure: we're missing the |
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
171cfa3
to
b4c2a96
Compare
|
@GrahamcOfBorg test systemd-networkd |
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
b4c2a96
to
171f27d
Compare
|
The aarch test fails because of #61602. I think it's safe to ignore it for now. @GrahamcOfBorg test systemd-networkd |
flokli
force-pushed
the
nin-networkd-policy-rules
branch
from
171f27d
to
10d4beb
Compare
|
Rebased on top of the landed aarch64 fix in master. @GrahamcOfBorg test systemd-networkd |
picnoir
force-pushed
the
nin-networkd-policy-rules
branch
from
10d4beb
to
9897d83
Compare
|
Updated. I also removed some other 64bit integer occurrences in the process. Naive question: Nix 2.2 was released more than a year ago. Any reason to keep supporting Nix < 2.2? @GrahamcOfBorg test systemd-networkd |
Not sure, what do others think of it? |
|
On 03:22 04.03.20, Maximilian Bosch wrote:
> Naive question: Nix 2.2 was released more than a year ago. Any reason to keep supporting Nix < 2.2?
Not sure, what do others think of it?
IIRC we had that topic on IRC a few times. The conclusion was something
like we should be ~2y backwards compat. I am not sure how much of a
policy that is and who said it…
|
Motivation for this change
Mapping the systemd-networkd
RoutingPolicyRulesin the NixOS networkd module.Check the
RoutingPolicyRulesection in thesystemd.networkfor more informations.Things done
Added the relevant options in the module
Modified the current networkd NixOS test to test all these options.
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
cc @flokli @fpletz @andir