Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qimgv: init at 0.8.9 #81344

Merged
merged 2 commits into from Mar 2, 2020
Merged

qimgv: init at 0.8.9 #81344

merged 2 commits into from Mar 2, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 29, 2020

A few notes:

  • I only run Linux, so that is what I set meta.platforms to. It may or may not build/work on darwin.
  • Video support is broken in both Nix and Arch builds.
Motivation for this change

I use qimgv all the time. Now I can use it via Nix :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
qimgv: init at 0.8.9
69de534 
A few notes:

* I only run Linux, so that is what I set `meta.platforms` to.
* Video support is broken in both Nix and Arch builds.
@cole-h
maintainers: add cole-h
7299acf
@teto
Copy link
Member

teto commented Feb 29, 2020

Tested with nixpkgs-review , worked well !

`warning:` unknown setting 'experimental-features'
warning: unknown setting 'experimental-features'
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/teto/.cache/nixpkgs-review/pr-81344/build.nix
warning: unknown setting 'experimental-features'
[3 built, 8 copied (12.0 MiB), 1.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81344
1 package built:
qimgv

warning: unknown setting 'experimental-features'
$ nix-shell /home/teto/.cache/nixpkgs-review/pr-81344/shell.nix
warning: unknown setting 'experimental-features'

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/108

@teto teto merged commit ecf79a0 into NixOS:master Mar 2, 2020
@cole-h cole-h deleted the qimgv branch March 2, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @teto @nixos-discourse