Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.stack: get building with ghc882 #81373

Merged
merged 2 commits into from Mar 1, 2020
Merged

haskellPackages.stack: get building with ghc882 #81373

merged 2 commits into from Mar 1, 2020

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Feb 29, 2020 •
edited by jonringer

Motivation for this change

This gets haskellPackages.stack building again after the update to ghc882.

Fixes #81338.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build stack

@cdepillabout cdepillabout mentioned this pull request Feb 29, 2020
Closed
@cdepillabout
Copy link
Member Author

I've tested that stack actually works by using it to build and run spago.

Everything seems to work.

jonringer
jonringer approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
i feel like the stack-ghc882-support.patch should be upstreamed (if not already)

otherwise LGTM

[6 built, 319 copied (3158.5 MiB), 217.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81373
3 package built:
haskellPackages.pantry haskellPackages.stack stack

@cdepillabout cdepillabout merged commit 4f36e9f into NixOS:haskell-updates Mar 1, 2020
@cdepillabout cdepillabout deleted the fixup-stack-for-ghc882 branch March 1, 2020 01:38
@cdepillabout
Copy link
Member Author

i feel like the stack-ghc882-support.patch should be upstreamed (if not already)

These patches have not been upstreamed. Normally I hate carrying around patches in our source tree, but let me give my reasons for not upstreaming this:

  1. The currently released version of stack is 2.1.3.1. However, upstream master has already diverged significantly from the code for 2.1.3.1. It is not clear that upstreaming this patch would even be helpful for the stack developers.
  2. The actual patch is very simple. Any of the stack developers would be able to figure out these changes easily. I wouldn't really be saving anyone any time by upstreaming it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdepillabout @jonringer