Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc: use ld.gold on linux for GHC 8.8.3 #81357

Closed
wants to merge 1 commit into from
Closed

ghc: use ld.gold on linux for GHC 8.8.3 #81357

wants to merge 1 commit into from

Conversation

adamse
Copy link
Contributor

@adamse adamse commented Feb 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adamse adamse mentioned this pull request Feb 29, 2020
Merged
10 tasks
@adamse
Copy link
Contributor Author

adamse commented Feb 29, 2020 •
edited

This is the same change as in #80466 ported to the just released 8.8.3.

Would some refactoring of the ghc derivations to share more of this configuration code be welcome?

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.compilers.ghc883

@domenkozar
Copy link
Member

#81318

@domenkozar domenkozar closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamse @cdepillabout @domenkozar