Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] smartmontools: 7.0 -> 7.1 and devicedb updated to latest #81423

Merged
merged 2 commits into from Mar 1, 2020
Merged

[20.03] smartmontools: 7.0 -> 7.1 and devicedb updated to latest #81423

merged 2 commits into from Mar 1, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Mar 1, 2020 •
edited

Motivation for this change

https://www.smartmontools.org/browser/tags/RELEASE_7_1/smartmontools/NEWS

Currently, we have 1+ year old devicedb.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman Frostman changed the base branch from master to release-20.03 March 1, 2020 08:25
@Frostman Frostman mentioned this pull request Mar 1, 2020
Merged
10 tasks
@worldofpeace
Copy link
Contributor

Currently, we have 1+ year old devicedb.

It appear they release once a year consistently.
Given that was just 2019-12-30, no too long ago, it hope it's fine.

@andir
Copy link
Member

andir commented Mar 1, 2020

Usually these are fine. I remember having updated them on 19.09 (or 19.03?) because my by then current hardware wasn't even remotely being supported. This should generally be a good QoL improvement and not much of a risk.

@worldofpeace worldofpeace merged commit f0ad76b into NixOS:release-20.03 Mar 1, 2020
@Frostman Frostman deleted the 20.03-smartmontools-7.1 branch March 2, 2020 04:18
@Frostman
Copy link
Member Author

Frostman commented Mar 2, 2020

@worldofpeace I was talking about devicedb, not about the smartmontools. Last time we had an update to it about a year ago from trunk and I took from trunk again in that PR. I've added to my list to monitor changes in it to update probably about every quarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @andir @worldofpeace