Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZHF] pythonPackages.astroquery 0.3.10 -> 0.4 #81409

Merged
merged 1 commit into from Mar 1, 2020
Merged

[ZHF] pythonPackages.astroquery 0.3.10 -> 0.4 #81409

merged 1 commit into from Mar 1, 2020

Conversation

smaret
Copy link
Member

@smaret smaret commented Feb 29, 2020

Motivation for this change

Backport #80552 to the 20.03 release branch.

ZHF: #80379
cc @NixOS/nixos-release-managers

@xbreak @smaret
pythonPackages.astroquery 0.3.10 -> 0.4
aa11950 
Tests are disabled until pytest-astropy is updated with
pytest-astropy-header.

(cherry picked from commit a5e82af)
@pvgoran
Copy link
Contributor

pvgoran commented Mar 1, 2020

Doing random review.

I was able to successfully build the PR and use the module:

> nix-shell -p nixpkgs-review --run "nixpkgs-review pr 81409"
...
[nix-shell:~/.cache/nixpkgs-review/pr-81409-1]$ python3.8
Python 3.8.1 (default, Dec 18 2019, 19:06:26) 
[GCC 9.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from astroquery.simbad import Simbad
Downloading https://hpiers.obspm.fr/iers/bul/bulc/Leap_Second.dat
|==================================================================================| 1.3k/1.3k (100.00%)         0s
>>> result_table = Simbad.query_object("m1")
>>> result_table.pprint(show_unit=True)
MAIN_ID      RA         DEC     RA_PREC DEC_PREC ... COO_ERR_ANGLE COO_QUAL COO_WAVELENGTH     COO_BIBCODE    
          "h:m:s"     "d:m:s"                    ...      deg                                                 
------- ----------- ----------- ------- -------- ... ------------- -------- -------------- -------------------
  M   1 05 34 31.94 +22 00 52.2       6        6 ...             0        C              R 2011A&A...533A..10L

@worldofpeace worldofpeace merged commit 78414b6 into NixOS:release-20.03 Mar 1, 2020
@smaret smaret deleted the release-20.03 branch March 1, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer jonringer is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smaret @pvgoran @worldofpeace @xbreak