Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hg-evolve: enable doCheck #81320

Closed
wants to merge 1 commit into from
Closed

hg-evolve: enable doCheck #81320

wants to merge 1 commit into from

Conversation

xavierzwirtz
Copy link
Contributor

Motivation for this change

hg-evolve package had doCheck disabled.

Things done

Removed doCheck = false.
Passed in mercurial as buildInput.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xavierzwirtz
hg-evolve: enable doCheck
e69cb99 
fixed hg-evolve checkPhase by passing mercurial as a buildInput
removed doCheck = false
@xavierzwirtz xavierzwirtz mentioned this pull request Feb 28, 2020
Merged
10 tasks
@xavierzwirtz
Copy link
Contributor Author

I am not sure what to do about the grahamcofborg-eval-nixpkgs-unstable-jobset failure, building the package locally, and calling nixpkgs-review locally works.
Command I used to run nixpkgs-review locally:
nix-shell -p nixpkgs-review --run "nixpkgs-review rev hg-evolve-enable-checkPhase -p python3Packages.hg-evolve"

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@danbst
Copy link
Contributor

danbst commented Mar 5, 2020

hm, it builds fine but I see this in build output:

warning: no previously-included files found matching 'contrib'                                                                                                                                                       
warning: no previously-included files found matching '.hg-format-source'                                                                                                                                             
warning: no previously-included files matching '*' found under directory 'contrib'                                                                                                                                   
warning: no previously-included files found matching 'hgext3rd/evolve/hack'                                                                                                                                          
warning: no previously-included files found matching '.gitlab-ci.yml'                                                                                                                                                
warning: no previously-included files matching '*' found under directory 'hgext3rd/evolve/hack'                                                                                                                      
warning: no previously-included files found matching 'Makefile'                                                                                                                                                      
warning: no previously-included files found matching 'tests/test-inhibit.t'                                                                                                                                          
warning: no previously-included files found matching 'docs/tutorial/.netlify'                                                                                                                                        
no previously-included directories found matching 'debian'                                                                                                                                                           
writing manifest file 'hg_evolve.egg-info/SOURCES.txt'                                                                                                                                                               
running build_ext                                                                                                                                                                                                    

----------------------------------------------------------------------                                                                                                                                               
Ran 0 tests in 0.000s                                                                                                                                                                                                
                                                                                                                                                                                                                     
OK                                                                                                                                                                                                                   
Finished executing setuptoolsCheckPhase

I assume it doesn't run tests...

jonringer
jonringer reviewed Mar 5, 2020
View reviewed changes
pkgs/development/python-modules/hg-evolve/default.nix
Comment on lines +17 to +19
buildInputs = [
mercurial
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is likely not what you want.

The mercurial executables are available during build, but using the python module will probably not have that.... so you need to patch sources so it shells out to the mercurial tooling.

@FRidh
Copy link
Member

FRidh commented Mar 29, 2020

Nothing happening so closing.

@FRidh FRidh closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xavierzwirtz @jonringer @danbst @FRidh