Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rstudio: 1.2.1335 -> 1.2.5033 #81395

Merged
merged 1 commit into from Mar 9, 2020
Merged

rstudio: 1.2.1335 -> 1.2.5033 #81395

merged 1 commit into from Mar 9, 2020

Conversation

ciil
Copy link
Member

@ciil ciil commented Feb 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ehmry and changlinli February 29, 2020 17:56
@pvgoran
Copy link
Contributor

pvgoran commented Mar 1, 2020

Doing random review.

I was able to successfully build the package using nixpkgs-review, and run the resulting RStudio binary.

Screenshot_nixos_2020-03-01_10:08:52

aanderse
aanderse approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight forward enough looking bump, has the review+testing of at least one person... Merging based on feedback 👍

@aanderse aanderse merged commit 92b7df1 into NixOS:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@changlinli changlinli Awaiting requested review from changlinli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciil @pvgoran @aanderse