Start with types #1234
Closed
Start with types #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Feb 29, 2020
nixops/diff.py
Outdated
| @@ -31,12 +30,10 @@ def _default_handle(self): | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def get_deps(self): | |||
| # type: () -> List[Handler] | |||
| def get_deps(self) -> List[Handler]: | |||
| return self._dependencies | |||
|
|
|||
| def get_keys(self, *_: AnyStr) -> List[str]: | |||
There was a problem hiding this comment.
I don't even know what this code is doing :o
There was a problem hiding this comment.
To be honest, me neither. :)
There was a problem hiding this comment.
A handler is basically a handler of few attributes e.g handler(['region', 'instanceType']), which means it realizes the needed changes when those attributes are changed,
I think get_keys is just convenience to return the keys, don't remember why I added it to be honest :D
There was a problem hiding this comment.
or are you guys asking about *_: AnyStr which I don't what it does either :-)
grahamc
reviewed
Feb 29, 2020
nixops/diff.py
Outdated
| def get_deps(self) -> List[Handler]: | ||
| # This is List[Handler], but that name doesn't exist inside the | ||
| # class definition. | ||
| def get_deps(self) -> List[Any]: |
There was a problem hiding this comment.
I think this can be List[Handler] with from __future__ import annotations, give that a try?
TheWizardTower
force-pushed
the
start-with-types
branch
from
65430b7
to
ccd2fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me, again. More stuff I want some more eyeballs on.
Most of this is in nixops/diff.py, which already had some typing work done, but I think I found a few improvements.
Namely:
Solved a todo that was pending python3.JKLOL nope.Not sure if this is at all useful, I'm just following mypy and flycheck.
Looking forward to your critical feedback. :)