Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pypy{,3}: use openssl_1_1 #81310

Merged
merged 1 commit into from Feb 29, 2020
Merged

[20.03] pypy{,3}: use openssl_1_1 #81310

merged 1 commit into from Feb 29, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Feb 28, 2020

Motivation for this change

Backport of #81300, per #80746.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
pypy{,3}: use openssl_1_1
9a1966e 
"We now support building PyPy with OpenSSL 1.1 in our built-in _ssl
module, as well as maintaining support for previous versions."
-- https://pypy.readthedocs.io/en/latest/release-pypy2.7-v5.6.0.html

(cherry picked from commit 6d3fc35)
@emilazy emilazy requested a review from FRidh as a code owner February 28, 2020 18:17
@ofborg ofborg bot requested a review from andersk February 28, 2020 18:28
@worldofpeace worldofpeace merged commit 53b9ac8 into NixOS:release-20.03 Feb 29, 2020
@emilazy emilazy deleted the fix-pypy-openssl-20.03 branch February 29, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@andersk andersk Awaiting requested review from andersk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @worldofpeace