Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cocotb: 1.2.0 -> 1.3.0 #81417

Merged
merged 1 commit into from Mar 2, 2020
Merged

cocotb: 1.2.0 -> 1.3.0 #81417

merged 1 commit into from Mar 2, 2020

Conversation

JennToo
Copy link
Contributor

@JennToo JennToo commented Mar 1, 2020

Motivation for this change

New release of cocotb. Changelog: https://cocotb.readthedocs.io/en/latest/release_notes.html#cocotb-1-3-0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Mar 1, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind quoting the homepage link?

otherwise LGTM

@JennToo
Copy link
Contributor Author

JennToo commented Mar 1, 2020

@jonringer sorry I'm not sure I understand what you mean

@ofborg ofborg bot requested a review from matthuszagh March 1, 2020 00:51
@JennToo
Copy link
Contributor Author

JennToo commented Mar 1, 2020

Also I've never contributed to nixpkgs before, so if I've missed something please let me know!

@jonringer
Copy link
Contributor

change

homepage = https://github.com/cocotb/cocotb;

to

homepage = "https://github.com/cocotb/cocotb";

:)

otherwise LGTM

NixOS/rfcs#45

@matthuszagh
Copy link
Contributor

This looks ok to me. Thanks for the contribution @Nitori-!

@JennToo
cocotb: 1.2.0 -> 1.3.0
5eb754a 
The fix for the CC/CXX variables was merged some time before 1.3.0.

The `-Werror` seems to be new. It is removed in upstream's master so it
should be removable in the next release. Something in glibc is causing a
warning that is killing the build if `-Werror` isn't removed.
jonringer
jonringer approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
shows usage

[5 built, 1 copied (7.0 MiB), 1.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81417
3 package built:
python27Packages.cocotb python37Packages.cocotb python38Packages.cocotb

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.cocotb python37Packages.cocotb python38Packages.cocotb

@jonringer jonringer merged commit bebcf42 into NixOS:master Mar 2, 2020
@JennToo JennToo deleted the cocotb-1.3.0 branch March 2, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@matthuszagh matthuszagh Awaiting requested review from matthuszagh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JennToo @jonringer @matthuszagh @Janik-Haag