Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nixpkgs/nixos/doc/manual/configuration/modularity] lack environment.systemPackages option in the example #81352

Merged
merged 1 commit into from Feb 29, 2020
Merged

[nixpkgs/nixos/doc/manual/configuration/modularity] lack environment.systemPackages option in the example #81352

merged 1 commit into from Feb 29, 2020

Conversation

sepiabrown
Copy link
Contributor

@sepiabrown sepiabrown commented Feb 29, 2020 •
edited

lack environment.systemPackages option in the example which is used in the next paragraph to explain merging of the options defined by multiple modules.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sepiabrown
lack environment.systemPackages option in the example
a9363c3 
lack environment.systemPackages option in the example which is used in the next paragraph to explain merging of the options defined by multiple modules.
@sepiabrown sepiabrown requested a review from nbp as a code owner February 29, 2020 07:15
@nlewo nlewo merged commit 7948e67 into NixOS:master Feb 29, 2020
@nlewo
Copy link
Member

nlewo commented Feb 29, 2020

Thanks @sepiabrown.
Note I updated the commit message to prefix it with the topic nixos/manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sepiabrown @nlewo @Janik-Haag