deployment.py: more mypy type checking #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Mar 1, 2020
| @@ -1272,31 +1323,34 @@ def worker(r): | |||
| ) | |||
|
|
|||
| if is_machine(r): | |||
| # NOTE: unfortunate mypy doesn't check that | |||
| # is_machine calls an isinstance() function | |||
| m = cast(nixops.backends.MachineState, r) | |||
There was a problem hiding this comment.
In other places, I replaced is_machine() calls with an instanceof of my own. Maybe ugly ... I wonder if there is a way we could fix this without cast?
grahamc
reviewed
Mar 1, 2020
AmineChikhaoui
force-pushed
the
deployment_py_typing
branch
2 times, most recently
from
d88b0cc
to
6806eb1
Compare
AmineChikhaoui
force-pushed
the
deployment_py_typing
branch
from
6806eb1
to
320d4b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.