Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vessels "forget" prediction settings upon landing #2443

Closed
scimas opened this issue Jan 12, 2020 · 3 comments
Closed

Vessels "forget" prediction settings upon landing #2443

scimas opened this issue Jan 12, 2020 · 3 comments
Milestone

Comments

@scimas
Copy link
Contributor

scimas commented Jan 12, 2020

The trajectory prediction settings (tolerance and steps) are reset to default values as soon as a vessel touches the ground on any body. It would be preferable to not lose them. It gets slightly annoying when biome hopping.

I guess this will go along with #957.

@pleroy
Copy link
Member

pleroy commented Jan 12, 2020

I don't think it's related to #957: the part of that issue that has to do with the prediction has been done long ago, the part that has to do with the plotting frame was not done because it's not clear if it's a good idea.

In the situation that you describe, Principia stops managing the vessel as soon as it hits the ground and destroys the internal Vessel object. Thus the prediction, history, flight plan, parameters are all lost. Keeping the vessel around while it is managed by KSP would be quite hard: Principia has no control over what happens in that case, e.g., if the vessel starts moving on wheels or something. So we would need to peek at what KSP is doing and update the state of the vessel so that everything is consistent when we get back to managing it. This may be possible, but it would be a good chunk of tedious work.

@scimas
Copy link
Contributor Author

scimas commented Jan 14, 2020

Agreed that you shouldn't need to keep track of everything that happens to a vessel when Principia isn't even managing it. All I want is for those two settings to be persistent, all the other things not being available is not really a big deal. (Although the possibility of a flight plan right from launch to landing is so tempting 😄 )

Do vessels have some kind of unique ID? That way you only need to keep track of those two settings (and not the full state) as long as the vessel exists. When you start managing the vessel, if you get the same ID for the vessel, restore those settings.

Although I can see that you would need to keep track of every vessel being created and destroyed even if Principia never gets to managing them.

@pleroy
Copy link
Member

pleroy commented Jan 22, 2020

Fixed in #2455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants