Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rx: 0.3.1 -> 0.3.2 #77548

Merged
merged 1 commit into from Jan 13, 2020
Merged

rx: 0.3.1 -> 0.3.2 #77548

merged 1 commit into from Jan 13, 2020

Conversation

minijackson
Copy link
Member

Motivation for this change

New release again!

Changes: cloudhead/rx@v0.3.1...v0.3.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Br1ght0ne January 12, 2020 10:22
Br1ght0ne
Br1ght0ne approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minijackson
Copy link
Member Author

Oops, forgot to mention you, sorry about that ^^'

tomberek
tomberek approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on NixOS. Functions as expected.

jonringer
jonringer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
other's have tested :)

[4 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77548
1 package built:
rx

@jonringer jonringer merged commit 865851f into NixOS:master Jan 13, 2020
@minijackson minijackson deleted the rx-0.3.2 branch January 13, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomberek tomberek tomberek approved these changes

@jonringer jonringer jonringer approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minijackson @tomberek @jonringer @Br1ght0ne