iperf3: fix compilation to support authentication creds #77592
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service iperf3 defines authorizedUsersFile and rsaPrivateKey to enable authenticated iperf server. It requires iperf to be compiled with openssl. https://nixos.org/nixos/options.html#services.iperf3.authorizedusersfile
|
@GrahamcOfBorg build iperf3 |
|
@infinisil should I backport it to 19.09 as well as it's kinda not working by defined in config option? |
|
Now backported in 692a8ca :) |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Service iperf3 defines authorizedUsersFile and rsaPrivateKey to
enable authenticated iperf server. It requires iperf to be compiled
with openssl. Service iperf3 with enable auth fails now because of
the lack of corresponding flags in iperf3 compiled w/o openssl.
https://nixos.org/nixos/options.html#services.iperf3.authorizedusersfile
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)This change is