Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iperf3: fix compilation to support authentication creds #77592

Merged
merged 1 commit into from Jan 16, 2020
Merged

iperf3: fix compilation to support authentication creds #77592

merged 1 commit into from Jan 16, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jan 13, 2020 •
edited

Motivation for this change

Service iperf3 defines authorizedUsersFile and rsaPrivateKey to
enable authenticated iperf server. It requires iperf to be compiled
with openssl. Service iperf3 with enable auth fails now because of
the lack of corresponding flags in iperf3 compiled w/o openssl.

https://nixos.org/nixos/options.html#services.iperf3.authorizedusersfile

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
iperf3: fix compilation to support authentication creds
eabc138 
Service iperf3 defines authorizedUsersFile and rsaPrivateKey to
enable authenticated iperf server. It requires iperf to be compiled
with openssl.

https://nixos.org/nixos/options.html#services.iperf3.authorizedusersfile
@teto
Copy link
Member

teto commented Jan 13, 2020

@GrahamcOfBorg build iperf3

@ofborg ofborg bot requested a review from fpletz January 14, 2020 02:40
@infinisil infinisil merged commit 7869cd2 into NixOS:master Jan 16, 2020
@Frostman
Copy link
Member Author

@infinisil should I backport it to 19.09 as well as it's kinda not working by defined in config option?

@Frostman Frostman deleted the fix-iperf3-openssl branch January 16, 2020 22:53
@infinisil
Copy link
Member

infinisil commented Jan 17, 2020 •
edited

Now backported in 692a8ca :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Frostman @teto @infinisil @Janik-Haag