Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb-tools: use default openssl #77505

Merged
merged 1 commit into from Jan 11, 2020
Merged

mongodb-tools: use default openssl #77505

merged 1 commit into from Jan 11, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 11, 2020

#77503

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from vcunat January 11, 2020 10:17
@ofborg ofborg bot requested a review from ehmry January 11, 2020 10:35
jonringer
jonringer approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executables seem to work fine

[2 built, 4 copied (437.4 MiB), 107.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77505
1 package built:
mongodb-tools

@jonringer jonringer merged commit f5f0612 into NixOS:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @jonringer